rogarithm/knowledge_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix regex delimiter in plan Task 5

Browse Source 
Task 4 implementer discovered that # delimiter conflicts with literal #
inside [/?#] and [&#] character classes (PHP PCRE terminates the regex
early). Same patterns repeat in Task 5; pre-update so a re-execution
does not hit the same bug. Vimeo regex in Task 6 is unaffected (no
literal # in pattern body).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Yutaka Kurosaki
2026-05-09 10:51:48 +09:00
parent 5b6e344ee9
commit 6debaf93bc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/superpowers/plans/2026-05-09-media-embed.md
+4 -4
View File
@@ -522,10 +522,10 @@ In `MediaUrlResolver.php`, modify `detectYouTube()` and add helper methods:
private function detectYouTube(string $url): ?string private function detectYouTube(string $url): ?string
{ {
$patterns = [ $patterns = [
'#^https?://youtu\.be/([A-Za-z0-9_-]{11})(?:[/?#]|$)#', '~^https?://youtu\.be/([A-Za-z0-9_-]{11})(?:[/?#]|$)~',
'#^https?://(?:www\.|m\.)?youtube\.com/watch\?(?:[^#]*&)?v=([A-Za-z0-9_-]{11})(?:[&#]|$)#', '~^https?://(?:www\.|m\.)?youtube\.com/watch\?(?:[^#]*&)?v=([A-Za-z0-9_-]{11})(?:[&#]|$)~',
'#^https?://(?:www\.|m\.)?youtube\.com/shorts/([A-Za-z0-9_-]{11})(?:[/?#]|$)#', '~^https?://(?:www\.|m\.)?youtube\.com/shorts/([A-Za-z0-9_-]{11})(?:[/?#]|$)~',
'#^https?://(?:www\.|m\.)?youtube\.com/embed/([A-Za-z0-9_-]{11})(?:[/?#]|$)#', '~^https?://(?:www\.|m\.)?youtube\.com/embed/([A-Za-z0-9_-]{11})(?:[/?#]|$)~',
]; ];
$videoId = null; $videoId = null;
foreach ($patterns as $p) { foreach ($patterns as $p) {