From 1ce1fa23a4a76e6631788d7f1f2b252fd6ac1b29 Mon Sep 17 00:00:00 2001 From: Yutaka Kurosaki <> Date: Sun, 10 May 2026 12:50:57 +0900 Subject: [PATCH] Add documents.delete_translation lang key for editor button MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The editor's delete-translation button used `__('messages.documents.delete_translation') ?? __('messages.documents.delete')`, but `__()` returns the key string (not null) on miss so the `??` fallback never fires — the button rendered the literal key. Adds the missing key to all 16 locales (en+ja human-translated, others mirror en) and simplifies the blade to a single `__()` call. Plan doc also reflects the SQLite dropIndex requirement found during Task 2. --- docs/superpowers/plans/2026-05-10-article-i18n.md | 4 +++- src/lang/de/messages.php | 1 + src/lang/en/messages.php | 1 + src/lang/es/messages.php | 1 + src/lang/fr/messages.php | 1 + src/lang/hi/messages.php | 1 + src/lang/it/messages.php | 1 + src/lang/ja/messages.php | 1 + src/lang/ko/messages.php | 1 + src/lang/pl/messages.php | 1 + src/lang/pt-BR/messages.php | 1 + src/lang/ru/messages.php | 1 + src/lang/tr/messages.php | 1 + src/lang/uk/messages.php | 1 + src/lang/vi/messages.php | 1 + src/lang/zh-CN/messages.php | 1 + src/lang/zh-TW/messages.php | 1 + src/resources/views/livewire/document-editor.blade.php | 2 +- 18 files changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/superpowers/plans/2026-05-10-article-i18n.md b/docs/superpowers/plans/2026-05-10-article-i18n.md index 38e3f27..63cc302 100644 --- a/docs/superpowers/plans/2026-05-10-article-i18n.md +++ b/docs/superpowers/plans/2026-05-10-article-i18n.md @@ -369,8 +369,10 @@ return new class extends Migration DB::statement('ALTER TABLE documents DROP INDEX documents_search_index'); } - // 5. Drop translatable columns from documents + // 5. Drop translatable columns from documents. + // SQLite requires explicit dropIndex on the title index before dropColumn. Schema::table('documents', function (Blueprint $table) { + $table->dropIndex(['title']); $table->dropColumn(['title', 'content', 'rendered_html']); }); } diff --git a/src/lang/de/messages.php b/src/lang/de/messages.php index 9da92d1..9bbd662 100644 --- a/src/lang/de/messages.php +++ b/src/lang/de/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/en/messages.php b/src/lang/en/messages.php index 3cb2c26..a0d3a0a 100644 --- a/src/lang/en/messages.php +++ b/src/lang/en/messages.php @@ -44,6 +44,7 @@ 'fallback_notice' => 'A translation in your selected language is not available. Showing the :locale version.', 'add_translation' => 'Add translation', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/es/messages.php b/src/lang/es/messages.php index 64607f8..7e815b1 100644 --- a/src/lang/es/messages.php +++ b/src/lang/es/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/fr/messages.php b/src/lang/fr/messages.php index 376d507..6f0ccb5 100644 --- a/src/lang/fr/messages.php +++ b/src/lang/fr/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/hi/messages.php b/src/lang/hi/messages.php index eecf30c..2a464fe 100644 --- a/src/lang/hi/messages.php +++ b/src/lang/hi/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/it/messages.php b/src/lang/it/messages.php index 1ecb4c6..7c8afd5 100644 --- a/src/lang/it/messages.php +++ b/src/lang/it/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/ja/messages.php b/src/lang/ja/messages.php index 227d632..b5d9c9a 100644 --- a/src/lang/ja/messages.php +++ b/src/lang/ja/messages.php @@ -44,6 +44,7 @@ 'fallback_notice' => 'この記事には選択した言語の翻訳がありません。元の言語版を表示しています。', 'add_translation' => '翻訳を追加', 'set_as_default' => 'デフォルトに設定', + 'delete_translation' => '翻訳を削除', 'delete_translation_blocked' => 'デフォルト言語の翻訳は削除できません。', 'translation_tabs_label' => '言語', ], diff --git a/src/lang/ko/messages.php b/src/lang/ko/messages.php index 1d26cc5..88fdfe4 100644 --- a/src/lang/ko/messages.php +++ b/src/lang/ko/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/pl/messages.php b/src/lang/pl/messages.php index 279d2bb..e45cf20 100644 --- a/src/lang/pl/messages.php +++ b/src/lang/pl/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/pt-BR/messages.php b/src/lang/pt-BR/messages.php index 7fe4f63..7a0801b 100644 --- a/src/lang/pt-BR/messages.php +++ b/src/lang/pt-BR/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/ru/messages.php b/src/lang/ru/messages.php index 23684bf..e13d485 100644 --- a/src/lang/ru/messages.php +++ b/src/lang/ru/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/tr/messages.php b/src/lang/tr/messages.php index 06b57e1..47ec412 100644 --- a/src/lang/tr/messages.php +++ b/src/lang/tr/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/uk/messages.php b/src/lang/uk/messages.php index b456c55..c654f9a 100644 --- a/src/lang/uk/messages.php +++ b/src/lang/uk/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/vi/messages.php b/src/lang/vi/messages.php index 9f4cb46..366b8c8 100644 --- a/src/lang/vi/messages.php +++ b/src/lang/vi/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/zh-CN/messages.php b/src/lang/zh-CN/messages.php index f758df3..f11f5ec 100644 --- a/src/lang/zh-CN/messages.php +++ b/src/lang/zh-CN/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/lang/zh-TW/messages.php b/src/lang/zh-TW/messages.php index 185d6b7..2dbcc1d 100644 --- a/src/lang/zh-TW/messages.php +++ b/src/lang/zh-TW/messages.php @@ -44,6 +44,7 @@ 'translation_added' => 'Translation added.', 'translation_deleted' => 'Translation deleted.', 'set_as_default' => 'Set as default', + 'delete_translation' => 'Delete translation', 'delete_translation_blocked' => 'The default-language translation cannot be deleted.', 'translation_tabs_label' => 'Languages', ], diff --git a/src/resources/views/livewire/document-editor.blade.php b/src/resources/views/livewire/document-editor.blade.php index f687fa1..9f8c985 100644 --- a/src/resources/views/livewire/document-editor.blade.php +++ b/src/resources/views/livewire/document-editor.blade.php @@ -108,7 +108,7 @@ class="px-2 py-1 text-xs text-indigo-600 border border-indigo-300 rounded hover: wire:confirm="{{ __('messages.documents.delete_confirm') }}" type="button" class="px-2 py-1 text-xs text-red-600 border border-red-300 rounded hover:bg-red-50"> - {{ __('messages.documents.delete_translation') ?? __('messages.documents.delete') }} + {{ __('messages.documents.delete_translation') }} @endif